Repository navigation
Migration mise - #399
Merged
Merged
Migration mise#399
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files.github/workflows/publish-docs.yml
.github/workflows/storage-integration-server.yml
py-opsml/uv.lock
|
thorrester
marked this pull request as ready for review
May 14, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Short Summary
Replaces the
Makefile/.tool-versionsdev toolchain with mise. All task invocations — in CI, docs, and contributor-facing docs — now go throughmise run <task>instead ofmake <target>. Themise.tomlat the repo root is the new single source of truth for pinned tools and task definitions.Context
The project previously split dev tooling across a root
Makefile, apy-opsml/makefile, and a.tool-versionsfile (asdf-compatible). This worked but had a few rough edges: tasks were spread across two makefiles,working-directoryhad to be set per-step in CI, and tool versioning lived in a separate file from task definitions.mise.tomlconsolidates all of this. Tools (cmake,protoc,uv,pnpm,node) are pinned there alongside every dev task. Python and Rust are explicitly excluded from mise's tool management (disable_tools = ["python", "gitleaks"]) so they don't shadow the matrix versions set bysetup-pythonandrustupin CI — that's a non-obvious footgun that was explicitly worked around.CI workflows — Every workflow (
lints-test.yml,build-assets.yml,storage-integration-*.yml, etc.) now has ajdx/mise-action@v3.4.1step added before any task invocation, withinstall: trueandcache: true. Theworking-directory: ./py-opsmlandworking-directory: ./crateshacks are gone. Python matrix jobs now passUV_PYTHON: ${{ matrix.python-version }}as an env var instead of changing directory.Python lints —
mypyis replaced bytyin the lint commands (py:lints,py:lints-ci). This shows up in both themise.tomltask definitions and the updatedAGENTS.mdcommand reference.Docs and contributing —
AGENTS.md,CONTRIBUTING.md, andpy-opsml/docs/contributing.mdare updated to replace allmakeinvocations withmise runequivalents.mise.toml.tool-versionsmise.toml.github/workflows/lints-test.ymlUV_PYTHONenv per step.github/workflows/build-assets.yml.github/workflows/build-assets-dev.yml.github/workflows/storage-integration-client.ymlworking-directory: ./crates.github/workflows/storage-integration-server.yml.github/workflows/release-candidate.yml.github/workflows/examples.ymlworking-directory: ./py-opsml.github/workflows/publish-docs.ymlAGENTS.mdCONTRIBUTING.mdpy-opsml/makefilepy-opsml/pyproject.toml.gitignore/dev→.dev/(scoped to dotfile convention)Is this a Breaking Change?
No. All public interfaces, card APIs, Python bindings, HTTP contracts, and database schemas are unchanged. Contributors will need
miseinstalled (curl https://mise.run | sh && mise install) —maketargets are either removed or thin wrappers, so anyone running the old targets in CI or locally will need to update their workflow.